X-Git-Url: http://git.mutantstargoat.com?a=blobdiff_plain;f=src%2Fvulkan%2Fvkutil.cc;h=35a85dd0e3a378d52ae8cdf43a910bcecc0e54f6;hb=22347bb45e427ea763295d77da0de0d2ef9c2395;hp=051ee4dc7174b101c6301ba2924046ec7a55f34e;hpb=9148ff7614b1dc22fd5d1dcf6d74e2fb4ff13706;p=demo

diff --git a/src/vulkan/vkutil.cc b/src/vulkan/vkutil.cc
index 051ee4d..35a85dd 100644
--- a/src/vulkan/vkutil.cc
+++ b/src/vulkan/vkutil.cc
@@ -1,3 +1,4 @@
+#include <gmath/gmath.h>
 #include <vulkan/vulkan.h>
 #include <stdio.h>
 #include <stdint.h>
@@ -6,22 +7,31 @@
 #include <string>
 #include <vector>
 
+#include "allocator.h"
 #include "vkutil.h"
 
 /* global variables */
-
-VkSwapchainKHR vkswapchain;
-VkImage *vkswapchain_images;
-int vknext_swapchain_image;
-VkSurfaceKHR vksurface;
+VkPhysicalDevice vk_physical;
+VkDevice vk_device;
+VkCommandPool vk_pool;
+VkQueue vk_queue;
+VkSurfaceKHR vk_surface;
+VkSwapchainKHR vk_swapchain;
+
+VkPipeline *vkgparent_pipeline;
+VkFramebuffer *vkfbufs;
+VkRenderPass vkrpass;
 VkInstance vkinst;
-VkPhysicalDevice vkpdev;
-VkDevice vkdev;
-VkQueue vkq;
-VkCommandPool vkcmdpool;
 VkCommandBuffer vkcmdbuf;	/* primary command buffer */
 int vkqfamily;
 
+VkSemaphore vk_img_avail_sema;
+VkSemaphore vk_rend_done_sema;
+VkImage *vkswapchain_images;
+VkImageView *vkswapchain_views;
+int vknum_swapchain_images;
+int vk_curr_swapchain_image;
+
 /* static functions */
 static const char *get_device_name_str(VkPhysicalDeviceType type);
 static const char *get_memtype_flags_str(VkMemoryPropertyFlags flags);
@@ -46,10 +56,7 @@ bool vku_have_extension(const char *name)
 		vkext_count = 0;
 		vkEnumerateInstanceExtensionProperties(0, &vkext_count, 0);
 		if(vkext_count) {
-			if(!(vkext = (VkExtensionProperties *)malloc(vkext_count * sizeof *vkext))) {
-				perror("failed to allocate instance extension list");
-				return false;
-			}
+			vkext = new VkExtensionProperties[vkext_count];
 			vkEnumerateInstanceExtensionProperties(0, &vkext_count, vkext);
 
 			printf("instance extensions:\n");
@@ -75,10 +82,7 @@ bool vku_have_device_extension(const char *name)
 		vkdevext_count = 0;
 		vkEnumerateDeviceExtensionProperties(phys_devices[sel_dev], 0, &vkdevext_count, 0);
 		if(vkdevext_count) {
-			if(!(vkdevext = (VkExtensionProperties *)malloc(vkdevext_count * sizeof *vkdevext))) {
-				perror("failed to allocate device extension list");
-				return false;
-			}
+			vkdevext = new VkExtensionProperties[vkdevext_count];
 			vkEnumerateDeviceExtensionProperties(phys_devices[sel_dev], 0, &vkdevext_count, vkdevext);
 
 			printf("selected device extensions:\n");
@@ -137,7 +141,7 @@ bool vku_create_device()
 		fprintf(stderr, "failed to enumerate vulkan physical devices\n");
 		return false;
 	}
-	phys_devices = (VkPhysicalDevice *)malloc(num_devices * sizeof *phys_devices);
+	phys_devices = new VkPhysicalDevice[num_devices];
 	if(vkEnumeratePhysicalDevices(vkinst, &num_devices, phys_devices) != 0) {
 		fprintf(stderr, "failed to enumerate vulkan physical devices\n");
 		return false;
@@ -179,7 +183,7 @@ bool vku_create_device()
 		if(qprop_count <= 0) {
 			continue;
 		}
-		qprop = (VkQueueFamilyProperties *)malloc(qprop_count * sizeof *qprop);
+		qprop = new VkQueueFamilyProperties[qprop_count];
 		vkGetPhysicalDeviceQueueFamilyProperties(phys_devices[i], &qprop_count, qprop);
 
 		for(unsigned int j=0; j<qprop_count; j++) {
@@ -192,12 +196,12 @@ bool vku_create_device()
 				sel_qfamily = j;
 			}
 		}
-		free(qprop);
+		delete [] qprop;
 	}
 
 	if(sel_dev < 0 || sel_qfamily < 0) {
 		fprintf(stderr, "failed to find any device with a graphics-capable command queue\n");
-		vkDestroyDevice(vkdev, 0);
+		vkDestroyDevice(vk_device, 0);
 		return false;
 	}
 
@@ -223,16 +227,16 @@ bool vku_create_device()
 	dev_info.enabledExtensionCount = sizeof devext_names / sizeof *devext_names;
 	dev_info.ppEnabledExtensionNames = devext_names;
 
-	if(vkCreateDevice(phys_devices[sel_dev], &dev_info, 0, &vkdev) != 0) {
+	if(vkCreateDevice(phys_devices[sel_dev], &dev_info, 0, &vk_device) != 0) {
 		fprintf(stderr, "failed to create device %d\n", sel_dev);
 		return false;
 	}
 	printf("created device %d\n", sel_dev);
 
-	vkpdev = phys_devices[sel_dev];
+	vk_physical = phys_devices[sel_dev];
 	vkqfamily = sel_qfamily;
 
-	vkGetDeviceQueue(vkdev, sel_qfamily, 0, &vkq);
+	vkGetDeviceQueue(vk_device, sel_qfamily, 0, &vk_queue);
 
 	/* create command buffer pool */
 	memset(&cmdpool_info, 0, sizeof cmdpool_info);
@@ -240,15 +244,15 @@ bool vku_create_device()
 	cmdpool_info.flags = VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT;
 	cmdpool_info.queueFamilyIndex = sel_qfamily;
 
-	if(vkCreateCommandPool(vkdev, &cmdpool_info, 0, &vkcmdpool) != 0) {
-		fprintf(stderr, "failed to get command quque!\n");
+	if(vkCreateCommandPool(vk_device, &cmdpool_info, 0, &vk_pool) != 0) {
+		fprintf(stderr, "failed to get command queue!\n");
 		return false;
 	}
 
-	if(!(vkcmdbuf = vku_alloc_cmdbuf(vkcmdpool, VK_COMMAND_BUFFER_LEVEL_PRIMARY))) {
-		fprintf(stderr, "failed to create primary command buffer\n");
-		return false;
-	}
+	/*	if(!(vkcmdbuf = vku_alloc_cmdbuf(vk_pool, VK_COMMAND_BUFFER_LEVEL_PRIMARY))) {
+			fprintf(stderr, "failed to create primary command buffer\n");
+			return false;
+		} */
 
 	return true;
 }
@@ -256,17 +260,40 @@ bool vku_create_device()
 void vku_cleanup()
 {
 	if(vkinst) {
-		vkDeviceWaitIdle(vkdev);
-		vkDestroyCommandPool(vkdev, vkcmdpool, 0);
-		vkDestroyDevice(vkdev, 0);
+		vkDeviceWaitIdle(vk_device);
+		vkDestroyCommandPool(vk_device, vk_pool, 0);
+
+		vkDestroySemaphore(vk_device, vk_img_avail_sema, 0);
+		vkDestroySemaphore(vk_device, vk_rend_done_sema, 0);
+
+		vkDestroyDevice(vk_device, 0);
 		vkDestroyInstance(vkinst, 0);
 		vkinst = 0;
 	}
 
-	free(phys_devices);
+	delete [] phys_devices;
 	phys_devices = 0;
 }
 
+bool vku_create_semaphores()
+{
+	VkSemaphoreCreateInfo sinf;
+	memset(&sinf, 0, sizeof sinf);
+
+	sinf.sType = VK_STRUCTURE_TYPE_SEMAPHORE_CREATE_INFO;
+	if(vkCreateSemaphore(vk_device, &sinf, 0, &vk_img_avail_sema) != VK_SUCCESS) {
+		fprintf(stderr, "Failed to create semaphore\n");
+		return false;
+	}
+
+	if(vkCreateSemaphore(vk_device, &sinf, 0, &vk_rend_done_sema) != VK_SUCCESS) {
+		fprintf(stderr, "Failed to create semaphore\n");
+		return false;
+	}
+
+	return true;
+}
+
 VkCommandBuffer vku_alloc_cmdbuf(VkCommandPool pool, VkCommandBufferLevel level)
 {
 	VkCommandBuffer cmdbuf;
@@ -278,15 +305,33 @@ VkCommandBuffer vku_alloc_cmdbuf(VkCommandPool pool, VkCommandBufferLevel level)
 	inf.level = level;
 	inf.commandBufferCount = 1;
 
-	if(vkAllocateCommandBuffers(vkdev, &inf, &cmdbuf) != 0) {
+	if(vkAllocateCommandBuffers(vk_device, &inf, &cmdbuf) != 0) {
 		return 0;
 	}
 	return cmdbuf;
 }
 
+bool vku_alloc_cmdbufs(VkCommandPool pool, VkCommandBufferLevel level, unsigned int count, VkCommandBuffer *buf_array)
+{
+	VkCommandBufferAllocateInfo cinf;
+	memset(&cinf, 0, sizeof cinf);
+
+	cinf.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
+	cinf.commandPool = vk_pool;
+	cinf.level = level;
+	cinf.commandBufferCount = count;
+
+	if(vkAllocateCommandBuffers(vk_device, &cinf, buf_array) != VK_SUCCESS) {
+		fprintf(stderr, "Failed to allocate command buffer\n");
+		return false;
+	}
+
+	return true;
+}
+
 void vku_free_cmdbuf(VkCommandPool pool, VkCommandBuffer buf)
 {
-	vkFreeCommandBuffers(vkdev, pool, 1, &buf);
+	vkFreeCommandBuffers(vk_device, pool, 1, &buf);
 }
 
 void vku_begin_cmdbuf(VkCommandBuffer buf, unsigned int flags)
@@ -323,56 +368,44 @@ void vku_submit_cmdbuf(VkQueue q, VkCommandBuffer buf, VkFence done_fence)
 	vkQueueSubmit(q, 1, &info, done_fence);
 }
 
-VkSwapchainKHR vku_create_swapchain(VkSurfaceKHR surf, int xsz, int ysz, int n,
-                                    VkPresentModeKHR pmode, VkSwapchainKHR prev)
+bool vku_get_surface_format(VkPhysicalDevice gpu, VkSurfaceKHR surface, VkSurfaceFormatKHR *sformat)
 {
-	VkSwapchainKHR sc;
-	VkSwapchainCreateInfoKHR inf;
+	uint32_t fcount;
 
-	memset(&inf, 0, sizeof inf);
-	inf.sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR;
-	inf.surface = surf;
-	inf.minImageCount = n;
-	inf.imageFormat = VK_FORMAT_B8G8R8A8_UNORM;	/* TODO enumerate and choose */
-	inf.imageColorSpace = VK_COLORSPACE_SRGB_NONLINEAR_KHR;
-	inf.imageExtent.width = xsz;
-	inf.imageExtent.height = ysz;
-	inf.imageArrayLayers = 1;
-	inf.imageUsage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
-	inf.imageSharingMode = VK_SHARING_MODE_EXCLUSIVE;	/* XXX make this an option? */
-	inf.preTransform = VK_SURFACE_TRANSFORM_INHERIT_BIT_KHR;
-	inf.compositeAlpha = VK_COMPOSITE_ALPHA_OPAQUE_BIT_KHR;
-	inf.presentMode = pmode;
-	inf.oldSwapchain = prev;
-
-	if(vkCreateSwapchainKHR(vkdev, &inf, 0, &sc) != 0) {
-		return 0;
+	if(vkGetPhysicalDeviceSurfaceFormatsKHR(vk_physical,
+	                                        vk_surface, &fcount, 0) != VK_SUCCESS) {
+		fprintf(stderr, "Failed to get format count for physical device.\n");
+		return false;
+	}
+	if(fcount == 0) {
+		fprintf(stderr, "No color formats were found.\n");
+		return false;
 	}
-	return sc;
-}
-
-VkImage *vku_get_swapchain_images(VkSwapchainKHR sc, int *count)
-{
-	uint32_t nimg;
-	VkImage *images;
 
-	if(vkGetSwapchainImagesKHR(vkdev, sc, &nimg, 0) != 0) {
-		return 0;
+	VkSurfaceFormatKHR *formats = new VkSurfaceFormatKHR[fcount];
+	if(vkGetPhysicalDeviceSurfaceFormatsKHR(vk_physical, vk_surface,
+	                                        &fcount, formats) != VK_SUCCESS) {
+		delete [] formats;
+		fprintf(stderr, "Failed to get surface formats.\n");
+		return false;
 	}
-	if(!(images = (VkImage *)malloc(nimg * sizeof *images))) {
-		return 0;
+
+	*sformat = formats[0];
+
+	if((fcount == 1) && (formats[0].format == VK_FORMAT_UNDEFINED)) {
+		sformat->format = VK_FORMAT_B8G8R8_UNORM;
 	}
-	vkGetSwapchainImagesKHR(vkdev, sc, &nimg, images);
 
-	if(count) *count = (int)nimg;
-	return images;
+	delete [] formats;
+	return true;
 }
 
+
 int vku_get_next_image(VkSwapchainKHR sc)
 {
 	uint32_t next;
 
-	if(vkAcquireNextImageKHR(vkdev, sc, UINT64_MAX, 0, 0, &next) != 0) {
+	if(vkAcquireNextImageKHR(vk_device, sc, UINT64_MAX, 0, 0, &next) != 0) {
 		return -1;
 	}
 	return (int)next;
@@ -391,7 +424,7 @@ void vku_present(VkSwapchainKHR sc, int img_idx)
 	inf.pImageIndices = &index;
 	inf.pResults = &res;
 
-	vkQueuePresentKHR(vkq, &inf);
+	vkQueuePresentKHR(vk_queue, &inf);
 }
 
 struct vku_buffer *vku_create_buffer(int sz, unsigned int usage)
@@ -399,10 +432,7 @@ struct vku_buffer *vku_create_buffer(int sz, unsigned int usage)
 	struct vku_buffer *buf;
 	VkBufferCreateInfo binfo;
 
-	if(!(buf = (vku_buffer *)malloc(sizeof *buf))) {
-		perror("failed to allocate vk_buffer structure");
-		return 0;
-	}
+	buf = new vku_buffer;
 
 	memset(&binfo, 0, sizeof binfo);
 	binfo.sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
@@ -410,19 +440,31 @@ struct vku_buffer *vku_create_buffer(int sz, unsigned int usage)
 	binfo.usage = usage;
 	binfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
 
-	if(vkCreateBuffer(vkdev, &binfo, 0, &buf->buf) != 0) {
+	if(vkCreateBuffer(vk_device, &binfo, 0, &buf->buf) != 0) {
 		fprintf(stderr, "failed to create %d byte buffer (usage: %x)\n", sz, usage);
 		return 0;
 	}
-	// TODO back with memory
+
+	VkMemoryRequirements mr;
+	vkGetBufferMemoryRequirements(vk_device, buf->buf, &mr);
+
+	DevMemBlock block;
+	if(!vku_allocate(mr.size, &block))
+		return 0;
+
+	buf->mem_pool = block.dev_mem;
+
 	return buf;
 }
 
 void vku_destroy_buffer(struct vku_buffer *buf)
 {
 	if(buf) {
-		vkDestroyBuffer(vkdev, buf->buf, 0);
-		free(buf);
+		//TODO change when the allocator changes
+		vku_free(buf->mem_pool);
+
+		vkDestroyBuffer(vk_device, buf->buf, 0);
+		delete buf;
 	}
 }
 
@@ -437,257 +479,6 @@ void vku_cmd_copybuf(VkCommandBuffer cmdbuf, VkBuffer dest, int doffs,
 	vkCmdCopyBuffer(cmdbuf, src, dest, 1, &copy);
 }
 
-/* paste
-
-static bool create_instance()
-{
-	uint32_t layer_count = 0;
-	std::vector<const char *> enabled_layers;
-
-	if(vkEnumerateInstanceLayerProperties(&layer_count, 0) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to query layer properties.\n");
-		return false;
-	}
-
-	if(layer_count > 0) {
-		VkLayerProperties *layers = (VkLayerProperties *)alloca(layer_count * sizeof *layers);
-		vkEnumerateInstanceLayerProperties(&layer_count, layers);
-		for(uint32_t i=0; i<layer_count; i++) {
-			if(strcmp(layers[i].layerName, "VK_LAYER_LUNARG_standard_validation")) {
-				enabled_layers.push_back(layers[i].layerName);
-			}
-		}
-	}
-
-	uint32_t extensions_count = 0;
-	std::vector<const char *> enabled_extensions;
-
-	if(vkEnumerateInstanceExtensionProperties(0, &extensions_count, 0) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to enumerate instance extension properties\n");
-		return false;
-	}
-
-	if(extensions_count > 0) {
-		VkExtensionProperties *extensions = (VkExtensionProperties *)alloca(extensions_count * sizeof *extensions);
-		vkEnumerateInstanceExtensionProperties(0, &extensions_count, extensions);
-
-		for(uint32_t i=0; i<extensions_count; i++) {
-			printf("Extension %u: %s %u.\n", i, extensions[i].extensionName, extensions[i].specVersion);
-			//enable all the available extensions
-			enabled_extensions.push_back(extensions[i].extensionName);
-			enabled_extension_names.push_back(std::string(extensions[i].extensionName));
-		}
-	}
-
-	VkInstanceCreateInfo create_info;
-	memset(&create_info, 0, sizeof create_info);
-	create_info.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO;
-
-	if(!enabled_layers.empty()) {
-		create_info.enabledLayerCount = enabled_layers.size();
-		create_info.ppEnabledLayerNames = enabled_layers.data();
-	}
-
-	if(!enabled_extensions.empty()) {
-		create_info.enabledExtensionCount = enabled_extensions.size();
-		create_info.ppEnabledExtensionNames = enabled_extensions.data();
-	}
-
-	if(vkCreateInstance(&create_info, 0, &inst) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to create instance.\n");
-		return false;
-	}
-
-	if(!create_device())
-		return false;
-
-	return true;
-}
-
-static bool create_device()
-{
-	int qfam_idx = -1;
-	int pdev_idx = -1;
-
-	uint32_t dev_count;
-	if(vkEnumeratePhysicalDevices(inst, &dev_count, 0) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to enumerate physical devices.\n");
-		return false;
-	}
-	printf("%u devices found.\n", (unsigned int)dev_count);
-
-	VkPhysicalDevice *phys_dev = (VkPhysicalDevice *)alloca(dev_count * sizeof *phys_dev);
-	vkEnumeratePhysicalDevices(inst, &dev_count, phys_dev);
-	VkPhysicalDeviceMemoryProperties memprop;
-
-	for(uint32_t i=0; i<dev_count; i++) {
-		VkPhysicalDeviceProperties dev_props;
-		vkGetPhysicalDeviceProperties(phys_dev[i], &dev_props);
-
-		//memory heaps:
-		vkGetPhysicalDeviceMemoryProperties(phys_dev[i], &memprop);
-		printf("\tNumber of heaps: %u\n", memprop.memoryHeapCount);
-		for(uint32_t j=0; j<memprop.memoryHeapCount; j++) {
-			printf("\t\tHeap %u size: %lu\n", j, (unsigned long)memprop.memoryHeaps[j].size);
-			printf("\t\tHeap %u flags: %s\n", j, heap_flags_str(memprop.memoryHeaps[j].flags));
-		}
-		//memory types
-		printf("\tMemory types: %u\n", memprop.memoryTypeCount);
-		for(uint32_t j=0; j<memprop.memoryTypeCount; j++) {
-			printf("\t\tType %u heap index: %u\n", j, memprop.memoryTypes[j].heapIndex);
-			printf("\t\tType %u flags: %s\n", j, memtype_flags_str(memprop.memoryTypes[j].propertyFlags));
-		}
-
-		//supported features
-		VkPhysicalDeviceFeatures features;
-		vkGetPhysicalDeviceFeatures(phys_dev[i], &features);
-
-		//queue families
-		uint32_t qfam_count;
-		vkGetPhysicalDeviceQueueFamilyProperties(phys_dev[i], &qfam_count, 0);
-		printf("\tQueue Families: %u\n", qfam_count);
-		VkQueueFamilyProperties *qfam_props = new VkQueueFamilyProperties[qfam_count];
-		vkGetPhysicalDeviceQueueFamilyProperties(phys_dev[i], &qfam_count, qfam_props);
-		for(uint32_t j=0; j<qfam_count; j++) {
-			printf("\t\tFamily %u flags: %s\n", j, queue_flags_str(qfam_props[j].queueFlags));
-			printf("\t\tFamily %u number of queues: %u\n", j, qfam_props[j].queueCount);
-
-			if((qfam_props[j].queueFlags & VK_QUEUE_GRAPHICS_BIT) && (pdev_idx == -1)) {
-				pdev_idx = i;
-				qfam_idx = j;
-				num_queues = qfam_props[j].queueCount;
-			}
-		}
-		delete [] qfam_props;
-	}
-
-	if(pdev_idx == -1) {
-		fprintf(stderr, "No suitable devices found.\n");
-		return false;
-	}
-
-	pdev = *(phys_dev + pdev_idx);
-	qfamily_idx = qfam_idx;
-
-		uint32_t layer_count;
-		if(vkEnumerateDeviceLayerProperties(pdev, &layer_count, 0) != VK_SUCCESS) {
-			fprintf(stderr, "Failed to enumerate device layers.\n");
-			return false;
-		}
-		if(layer_count > 0) {
-			VkLayerProperties *layers = (VkLayerProperties*)alloca(layer_count * sizeof *layers);
-			vkEnumerateDeviceLayerProperties(pdev, &layer_count, layers);
-			printf("%u layers found.\n", layer_count);
-			for(uint32_t i=0; i<layer_count; i++) {
-				printf("Layer %u: %s (%u, %u)\n", i, layers[i].layerName,
-						layers[i].specVersion, layers[i].implementationVersion);
-				printf("\tDesc: %s\n", layers[i].description);
-			}
-		}
-
-	VkDeviceCreateInfo dev_info;
-	memset(&dev_info, 0, sizeof dev_info);
-	dev_info.sType = VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO;
-
-	VkDeviceQueueCreateInfo dev_qinfo;
-	memset(&dev_qinfo, 0, sizeof dev_qinfo);
-	dev_qinfo.sType = VK_STRUCTURE_TYPE_DEVICE_QUEUE_CREATE_INFO;
-	dev_qinfo.queueFamilyIndex = qfam_idx;
-	dev_qinfo.queueCount = 1;
-
-	dev_info.queueCreateInfoCount = 1;
-	dev_info.pQueueCreateInfos = &dev_qinfo;
-
-	if(vkCreateDevice(pdev, &dev_info, 0, &device) != VK_SUCCESS) {
-		fprintf(stderr, "Failed to create logical device.\n");
-		return false;
-	}
-
-	vkGetPhysicalDeviceMemoryProperties(pdev, &memprop);
-	for(uint32_t j=0; j<memprop.memoryTypeCount; j++) {
-		if(memprop.memoryTypes[j].propertyFlags & VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT) {
-			device_mem_idx = j;
-			printf("Selected device memory index: %u\n", device_mem_idx);
-			break;
-		}
-	}
-
-	return true;
-}
-
-static const char *dev_type_str(VkPhysicalDeviceType type)
-{
-	switch(type) {
-	case VK_PHYSICAL_DEVICE_TYPE_OTHER:
-		return "other";
-	case VK_PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU:
-		return "integrated GPU";
-	case VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU:
-		return "discrete GPU";
-	case VK_PHYSICAL_DEVICE_TYPE_VIRTUAL_GPU:
-		return "virtual GPU";
-	case VK_PHYSICAL_DEVICE_TYPE_CPU:
-		return "CPU";
-	default:
-		break;
-	}
-	return "unknown";
-}
-
-static const char *heap_flags_str(VkMemoryHeapFlags flags)
-{
-	static std::string str;
-	str.clear();
-	if(flags & VK_MEMORY_HEAP_DEVICE_LOCAL_BIT) {
-		str += "device-local ";
-	}
-	if(!str.empty())
-		str.pop_back();
-	return str.c_str();
-}
-
-static const char *memtype_flags_str(VkMemoryPropertyFlags flags)
-{
-	static std::string str;
-	str.clear();
-	if(flags & VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT) {
-		str += "device-local ";
-	}
-	if(flags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) {
-		str += "host-visible ";
-	}
-	if(flags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) {
-		str += "host-coherent ";
-	}
-	if(flags & VK_MEMORY_PROPERTY_HOST_CACHED_BIT) {
-		str += "host-cached ";
-	}
-	if(flags & VK_MEMORY_PROPERTY_LAZILY_ALLOCATED_BIT) {
-		str += "lazily-allocated ";
-	}
-	if(!str.empty())
-		str.pop_back();
-	return str.c_str();
-}
-
-static const char *queue_flags_str(VkQueueFlags flags)
-{
-	static std::string str;
-	str.clear();
-	if(flags & VK_QUEUE_GRAPHICS_BIT)
-		str += "graphics ";
-	if(flags & VK_QUEUE_COMPUTE_BIT)
-		str += "compute ";
-	if(flags & VK_QUEUE_TRANSFER_BIT)
-		str += "transfer ";
-	if(flags & VK_QUEUE_SPARSE_BINDING_BIT)
-		str += "sparse-binding ";
-	if(!str.empty())
-		str.pop_back();
-	return str.c_str();
-}
-*/
-
 const char *vku_get_vulkan_error_str(VkResult error)
 {
 	std::string errmsg;
@@ -733,7 +524,6 @@ const char *vku_get_vulkan_error_str(VkResult error)
 		break;
 	case VK_ERROR_FEATURE_NOT_PRESENT:
 		errmsg = std::string("VK_ERROR_FEATURE_NOT_PRESENT");
-		break;
 	case VK_ERROR_INCOMPATIBLE_DRIVER:
 		errmsg = std::string("VK_ERROR_INCOMPATIBLE_DRIVER");
 		break;
@@ -754,6 +544,7 @@ const char *vku_get_vulkan_error_str(VkResult error)
 	return errmsg.c_str();
 }
 
+
 static const char *get_device_name_str(VkPhysicalDeviceType type)
 {
 	switch(type) {