Lots of stuff that John F. Fay pointed out.
[freeglut] / src / freeglut_main.c
index 6a08d2d..8cea680 100644 (file)
@@ -101,9 +101,9 @@ static void fghRedrawWindowByHandle
      * XXX the {window} pointer is defined.
      */
     freeglut_return_if_fail( FETCH_WCB( *window, Display ) );
-    freeglut_return_if_fail( window->State.Visible == TRUE );
+    freeglut_return_if_fail( window->State.Visible );
 
-    window->State.Redisplay = FALSE;
+    window->State.Redisplay = GL_FALSE;
     INVOKE_WCB( *window, Display, ( ) );
 }
 
@@ -139,7 +139,7 @@ static void fghReshapeWindowByHandle
      * But without this we get this bad behaviour whenever we resize the
      * window.
      */
-    window->State.Redisplay = TRUE;
+    window->State.Redisplay = GL_TRUE;
 
     if( window->IsMenu )
         fgSetWindow( current_window );
@@ -161,12 +161,12 @@ static void fghcbDisplayWindow( SFG_Window *window, SFG_Enumerator *enumerator )
      * XXX loop if you didn't have a display callback defined...
      */
     if( ( FETCH_WCB( *window, Display ) ) &&
-        ( window->State.Redisplay == TRUE ) &&
-        ( window->State.Visible == TRUE ) )
+        window->State.Redisplay &&
+        window->State.Visible )
     {
-        SFG_Window *current_window = fgStructure.Window ;
+        SFG_Window *current_window = fgStructure.Window;
 
-        window->State.Redisplay = FALSE;
+        window->State.Redisplay = GL_FALSE;
         INVOKE_WCB( *window, Display, ( ) );
         fgSetWindow( current_window );
     }
@@ -185,7 +185,7 @@ static void fghcbDisplayWindow( SFG_Window *window, SFG_Enumerator *enumerator )
             glutGet( GLUT_WINDOW_HEIGHT )
         );
 
-        window->State.NeedToResize = FALSE;
+        window->State.NeedToResize = GL_FALSE;
         fgSetWindow ( current_window );
     }
 
@@ -193,10 +193,10 @@ static void fghcbDisplayWindow( SFG_Window *window, SFG_Enumerator *enumerator )
      * XXX See above comment about the Redisplay flag...
      */
     if( ( FETCH_WCB( *window, Display ) ) &&
-        ( window->State.Redisplay == TRUE ) &&
-        ( window->State.Visible == TRUE ) )
+        window->State.Redisplay &&
+        window->State.Visible )
     {
-        window->State.Redisplay = FALSE;
+        window->State.Redisplay = GL_FALSE;
 
         RedrawWindow(
             window->Window.Handle, NULL, NULL, 
@@ -216,8 +216,8 @@ static void fghDisplayAll( void )
 {
     SFG_Enumerator enumerator;
 
-    enumerator.found = FALSE;
-    enumerator.data  =  NULL;
+    enumerator.found = GL_FALSE;
+    enumerator.data  =     NULL;
 
     fgEnumWindows( fghcbDisplayWindow, &enumerator );
 }
@@ -247,8 +247,8 @@ static void fghCheckJoystickPolls( void )
 {
     SFG_Enumerator enumerator;
 
-    enumerator.found = FALSE;
-    enumerator.data  =  NULL;
+    enumerator.found = GL_FALSE;
+    enumerator.data  =     NULL;
 
     fgEnumWindows( fghcbCheckJoystickPolls, &enumerator );
 }
@@ -304,12 +304,12 @@ long fgElapsedTime( void )
     
         gettimeofday( &now, NULL );
     
-        elapsed = (now.tv_usec - fgState.Time.Value.tv_usec) / 1000;
-        elapsed += (now.tv_sec - fgState.Time.Value.tv_sec) * 1000;
+       elapsed  = ( now.tv_usec - fgState.Time.Value.tv_usec ) / 1000;
+       elapsed += ( now.tv_sec  - fgState.Time.Value.tv_sec  ) * 1000;
     
         return elapsed;
 #elif TARGET_HOST_WIN32
-        return timeGetTime() - fgState.Time.Value;
+       return timeGetTime( ) - fgState.Time.Value;
 #endif
     }
     else
@@ -319,7 +319,9 @@ long fgElapsedTime( void )
 #elif TARGET_HOST_WIN32
         fgState.Time.Value = timeGetTime( );
 #endif
-        fgState.Time.Set = TRUE;
+        fgState.Time.Set = GL_TRUE;
+
+        return 0;
     }
 }
 
@@ -332,14 +334,17 @@ void fgError( const char *fmt, ... )
 
     va_start( ap, fmt );
 
-    fprintf( stderr, "freeglut ");
+    fprintf( stderr, "freeglut " );
     if( fgState.ProgramName )
-        fprintf (stderr, "(%s): ", fgState.ProgramName);
+        fprintf( stderr, "(%s): ", fgState.ProgramName );
     vfprintf( stderr, fmt, ap );
     fprintf( stderr, "\n" );
 
     va_end( ap );
 
+    if ( fgState.Initialised )
+        fgDeinitialize( );
+
     exit( 1 );
 }
 
@@ -349,7 +354,7 @@ void fgWarning( const char *fmt, ... )
 
     va_start( ap, fmt );
 
-    fprintf( stderr, "freeglut ");
+    fprintf( stderr, "freeglut " );
     if( fgState.ProgramName )
         fprintf( stderr, "(%s): ", fgState.ProgramName );
     vfprintf( stderr, fmt, ap );
@@ -378,11 +383,11 @@ void fgWarning( const char *fmt, ... )
  * an opaque wall.
  *
  */
-static void fgCheckJoystickCallback( SFG_Window* w, SFG_Enumerator* e)
+static void fgCheckJoystickCallback( SFG_Window* w, SFG_Enumerator* e )
 {
     if( FETCH_WCB( *w, Joystick ) )
     {
-        e->found = TRUE;
+        e->found = GL_TRUE;
         e->data = w;
     }
     fgEnumSubWindows( w, fgCheckJoystickCallback, e );
@@ -390,24 +395,24 @@ static void fgCheckJoystickCallback( SFG_Window* w, SFG_Enumerator* e)
 static int fgHaveJoystick( void )
 {
     SFG_Enumerator enumerator;
-    enumerator.found = FALSE;
+    enumerator.found = GL_FALSE;
     enumerator.data = NULL;
     fgEnumWindows( fgCheckJoystickCallback, &enumerator );
     return !!enumerator.data;
 }
-static void fgHavePendingRedisplaysCallback( SFG_Window* w, SFG_Enumerator* e)
+static void fgHavePendingRedisplaysCallback( SFG_Window* w, SFG_Enumerator* e )
 {
     if( w->State.Redisplay )
     {
-        e->found = TRUE;
+        e->found = GL_TRUE;
         e->data = w;
     }
     fgEnumSubWindows( w, fgHavePendingRedisplaysCallback, e );
 }        
-static int fgHavePendingRedisplays (void)
+static int fgHavePendingRedisplays( void )
 {
     SFG_Enumerator enumerator;
-    enumerator.found = FALSE;
+    enumerator.found = GL_FALSE;
     enumerator.data = NULL;
     fgEnumWindows( fgHavePendingRedisplaysCallback, &enumerator );
     return !!enumerator.data;
@@ -415,23 +420,25 @@ static int fgHavePendingRedisplays (void)
 /*
  * Indicates whether there are any outstanding timers.
  */
+#if 0 /* Not used */
 static int fgHaveTimers( void )
 {
     return !!fgState.Timers.First;
 }
+#endif
 /*
  * Returns the number of GLUT ticks (milliseconds) till the next timer event.
  */
 static long fgNextTimer( void )
 {
-    long now = fgElapsedTime();
+    long now = fgElapsedTime( );
     long ret = INT_MAX;
     SFG_Timer *timer;
 
-    for( timer = (SFG_Timer *)fgState.Timers.First;
+    for( timer = ( SFG_Timer * )fgState.Timers.First;
          timer;
-         timer = (SFG_Timer *)timer->Node.Next )
-        ret = MIN( ret, MAX( 0, (timer->TriggerTime) - now ) );
+         timer = ( SFG_Timer * )timer->Node.Next )
+        ret = MIN( ret, MAX( 0, timer->TriggerTime - now ) );
 
     return ret;
 }
@@ -458,12 +465,12 @@ static void fgSleepForEvents( void )
     if( fgHaveJoystick( ) )
         msec = MIN( msec, 10 );
     
-    wait.tv_sec = msec / 1000;
-    wait.tv_usec = (msec % 1000) * 1000;
+    wait.tv_sec  =   msec / 1000;
+    wait.tv_usec = ( msec % 1000 ) * 1000;
     err = select( socket+1, &fdset, NULL, NULL, &wait );
 
     if( -1 == err )
-        printf( "freeglut select() error: %d\n", errno );
+        fgWarning( "freeglut select() error: %d\n", errno );
     
 #elif TARGET_HOST_WIN32
 #endif
@@ -528,8 +535,8 @@ void FGAPIENTRY glutMainLoopEvent( void )
             {
                 GETWINDOW( xclient ); 
 
-                fgCloseWindow ( window ) ;
-                fgAddToWindowDestroyList ( window, FALSE );
+                fgCloseWindow ( window );
+                fgAddToWindowDestroyList ( window, GL_FALSE );
             }
             break;
 
@@ -560,7 +567,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
              * This is sent to confirm the XDestroyWindow call.
              * XXX WHY is this commented out?  Should we re-enable it?
              */
-            /* fgAddToWindowDestroyList ( window, FALSE ); */
+            /* fgAddToWindowDestroyList ( window, GL_FALSE ); */
             break;
 
         case Expose:
@@ -608,18 +615,18 @@ void FGAPIENTRY glutMainLoopEvent( void )
             {
             case VisibilityUnobscured:
                 INVOKE_WCB( *window, WindowStatus, ( GLUT_FULLY_RETAINED ) );
-                window->State.Visible = TRUE;
+                window->State.Visible = GL_TRUE;
                 break;
                 
             case VisibilityPartiallyObscured:
                 INVOKE_WCB( *window, WindowStatus,
                             ( GLUT_PARTIALLY_RETAINED ) );
-                window->State.Visible = TRUE;
+                window->State.Visible = GL_TRUE;
                 break;
                 
             case VisibilityFullyObscured:
                 INVOKE_WCB( *window, WindowStatus, ( GLUT_FULLY_COVERED ) );
-                window->State.Visible = FALSE;
+                window->State.Visible = GL_FALSE;
                 break;
 
             default:
@@ -653,8 +660,8 @@ void FGAPIENTRY glutMainLoopEvent( void )
                     window->ActiveMenu->Window->State.MouseY =
                         event.xmotion.y_root - window->ActiveMenu->Y;
                 }
-                window->ActiveMenu->Window->State.Redisplay = TRUE ;
-                fgSetWindow( window->ActiveMenu->ParentWindow ) ;
+                window->ActiveMenu->Window->State.Redisplay = GL_TRUE;
+                fgSetWindow( window->ActiveMenu->ParentWindow );
 
                 break;
             }
@@ -663,11 +670,9 @@ void FGAPIENTRY glutMainLoopEvent( void )
              * XXX For more than 5 buttons, just check {event.xmotion.state},
              * XXX rather than a host of bit-masks?
              */
-            if( (event.xmotion.state & Button1Mask) ||
-                (event.xmotion.state & Button2Mask) ||
-                (event.xmotion.state & Button3Mask) ||
-                (event.xmotion.state & Button4Mask) ||
-                (event.xmotion.state & Button5Mask) )
+#define BUTTON_MASK \
+  ( Button1Mask | Button2Mask | Button3Mask | Button4Mask | Button5Mask )
+            if( event.xmotion.state & BUTTON_MASK )
                 INVOKE_WCB( *window, Motion, ( event.xmotion.x,
                                                event.xmotion.y ) );
             else
@@ -679,11 +684,11 @@ void FGAPIENTRY glutMainLoopEvent( void )
         case ButtonRelease:
         case ButtonPress:
         {
-            GLboolean pressed = TRUE;
+            GLboolean pressed = GL_TRUE;
             int button;
 
             if( event.type == ButtonRelease )
-                pressed = FALSE ;
+                pressed = GL_FALSE;
 
             /*
              * A mouse button has been pressed or released. Traditionally,
@@ -736,7 +741,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
               
                 /* In the menu, invoke the callback and deactivate the menu*/
                 if( fgCheckActiveMenu( window->ActiveMenu->Window,
-                                       window->ActiveMenu ) == TRUE )
+                                       window->ActiveMenu ) )
                 {
                     /*
                      * Save the current window and menu and set the current
@@ -766,7 +771,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
                      */
                     fgDeactivateMenu( window->ActiveMenu->ParentWindow );
               
-                window->State.Redisplay = TRUE;
+                window->State.Redisplay = GL_TRUE;
                 break;
             }
 
@@ -774,11 +779,11 @@ void FGAPIENTRY glutMainLoopEvent( void )
              * No active menu, let's check whether we need to activate one.
              */
             if( ( 0 <= button ) &&
-                ( 2 >= button ) &&
+                ( FREEGLUT_MAX_MENUS > button ) &&
                 ( window->Menu[ button ] ) &&
                 pressed )
             {
-                window->State.Redisplay = TRUE;
+                window->State.Redisplay = GL_TRUE;
                 fgSetWindow( window );
                 fgActivateMenu( window, button );
                 break;
@@ -795,7 +800,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
             /*
              * XXX Why don't we use {window}?  Other code here does...
              */
-            fgStructure.Window->State.Modifiers = fgGetXModifiers( &event );
+            fgState.Modifiers = fgGetXModifiers( &event );
 
             /*
              * Finally execute the mouse or mouse wheel callback
@@ -822,7 +827,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
                  * XXX Note that {button} has already been decremeted
                  * XXX in mapping from X button numbering to GLUT.
                  */
-                int wheel_number = (button - 3) / 2;
+                int wheel_number = ( button - 3 ) / 2;
                 int direction = -1;
                 if( button % 2 )
                     direction = 1;
@@ -838,7 +843,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
             /*
              * Trash the modifiers state
              */
-            fgStructure.Window->State.Modifiers = 0xffffffff;
+            fgState.Modifiers = 0xffffffff;
         }
         break;
 
@@ -876,7 +881,8 @@ void FGAPIENTRY glutMainLoopEvent( void )
                  * Check for the ASCII/KeySym codes associated with the event:
                  */
                 len = XLookupString( &event.xkey, asciiCode, sizeof(asciiCode),
-                                     &keySym, &composeStatus );
+                                     &keySym, &composeStatus
+                );
 
                 /*
                  * GLUT API tells us to have two separate callbacks...
@@ -889,10 +895,11 @@ void FGAPIENTRY glutMainLoopEvent( void )
                     if( keyboard_cb )
                     {
                         fgSetWindow( window );
-                        window->State.Modifiers = fgGetXModifiers( &event );
+                        fgState.Modifiers = fgGetXModifiers( &event );
                         keyboard_cb( asciiCode[ 0 ],
-                                     event.xkey.x, event.xkey.y );
-                        window->State.Modifiers = 0xffffffff;
+                                     event.xkey.x, event.xkey.y
+                        );
+                        fgState.Modifiers = 0xffffffff;
                     }
                 }
                 else
@@ -939,12 +946,12 @@ void FGAPIENTRY glutMainLoopEvent( void )
                      * Execute the callback (if one has been specified),
                      * given that the special code seems to be valid...
                      */
-                    if( special_cb && (special != -1) )
+                    if( special_cb && ( special != -1 ) )
                     {
                         fgSetWindow( window );
-                        window->State.Modifiers = fgGetXModifiers( &event );
+                        fgState.Modifiers = fgGetXModifiers( &event );
                         special_cb( special, event.xkey.x, event.xkey.y );
-                        window->State.Modifiers = 0xffffffff;
+                        fgState.Modifiers = 0xffffffff;
                     }
                 }
             }
@@ -955,7 +962,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
             break; /* XXX Should disable this event */
 
         default:
-            fgWarning ("Unknown X event type: %d", event.type);
+            fgWarning( "Unknown X event type: %d", event.type );
             break;
         }
     }
@@ -967,7 +974,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
     while( PeekMessage( &stMsg, NULL, 0, 0, PM_NOREMOVE ) )
     {
         if( GetMessage( &stMsg, NULL, 0, 0 ) == 0 )
-            fgState.ExecState = GLUT_EXEC_STATE_STOP ;
+            fgState.ExecState = GLUT_EXEC_STATE_STOP;
 
         TranslateMessage( &stMsg );
         DispatchMessage( &stMsg );
@@ -988,7 +995,7 @@ void FGAPIENTRY glutMainLoopEvent( void )
 void FGAPIENTRY glutMainLoop( void )
 {
 #if TARGET_HOST_WIN32
-    SFG_Window *window = (SFG_Window *)fgStructure.Windows.First ;
+    SFG_Window *window = (SFG_Window *)fgStructure.Windows.First;
 #endif
 
     freeglut_assert_ready;
@@ -1005,19 +1012,19 @@ void FGAPIENTRY glutMainLoop( void )
      */
     while( window )
     {
-        if ( FETCH_WCB( *window, Visibility ) )
+        if( FETCH_WCB( *window, Visibility ) )
         {
-            SFG_Window *current_window = fgStructure.Window ;
+            SFG_Window *current_window = fgStructure.Window;
 
             INVOKE_WCB( *window, Visibility, ( window->State.Visible ) );
             fgSetWindow( current_window );
         }
         
-        window = (SFG_Window *)window->Node.Next ;
+        window = (SFG_Window *)window->Node.Next;
     }
 #endif
 
-    fgState.ExecState = GLUT_EXEC_STATE_RUNNING ;
+    fgState.ExecState = GLUT_EXEC_STATE_RUNNING;
     while( fgState.ExecState == GLUT_EXEC_STATE_RUNNING )
     {
         glutMainLoopEvent( );
@@ -1029,7 +1036,7 @@ void FGAPIENTRY glutMainLoop( void )
             if( fgState.IdleCallback )
                 fgState.IdleCallback( );
 
-            fgSleepForEvents();
+            fgSleepForEvents( );
         }
     }
 
@@ -1043,7 +1050,7 @@ void FGAPIENTRY glutMainLoop( void )
         fgDeinitialize( );
 
         if( execState == GLUT_ACTION_EXIT )
-            exit( 0 ) ;
+            exit( 0 );
     }
 }
 
@@ -1052,7 +1059,7 @@ void FGAPIENTRY glutMainLoop( void )
  */
 void FGAPIENTRY glutLeaveMainLoop( void )
 {
-    fgState.ExecState = GLUT_EXEC_STATE_STOP ;
+    fgState.ExecState = GLUT_EXEC_STATE_STOP;
 }
 
 
@@ -1082,7 +1089,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
     LONG lRet = 1;
 
     if ( ( window == NULL ) && ( uMsg != WM_CREATE ) )
-      return( DefWindowProc( hWnd, uMsg, wParam, lParam ) );
+      return DefWindowProc( hWnd, uMsg, wParam, lParam );
 
     /* printf ( "Window %3d message <%04x> %12d %12d\n", window?window->ID:0,
              uMsg, wParam, lParam ); */
@@ -1097,16 +1104,17 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
 
         window->Window.Handle = hWnd;
         window->Window.Device = GetDC( hWnd );
-        if( fgState.BuildingAMenu )
+        if( window->IsMenu )
         {
             unsigned int current_DisplayMode = fgState.DisplayMode;
             fgState.DisplayMode = GLUT_DOUBLE | GLUT_RGB | GLUT_DEPTH;
-            fgSetupPixelFormat( window, FALSE, PFD_MAIN_PLANE );
+            fgSetupPixelFormat( window, GL_FALSE, PFD_MAIN_PLANE );
             fgState.DisplayMode = current_DisplayMode;
 
             if( fgStructure.MenuContext )
                 wglMakeCurrent( window->Window.Device,
-                                fgStructure.MenuContext->Context ) ;
+                                fgStructure.MenuContext->Context
+                );
             else
             {
                 fgStructure.MenuContext =
@@ -1115,14 +1123,14 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
                     wglCreateContext( window->Window.Device );
             }
 
-            /* window->Window.Context = wglGetCurrentContext () ;   */
+            /* window->Window.Context = wglGetCurrentContext( );   */
             window->Window.Context = wglCreateContext( window->Window.Device );
         }
         else
         {
-            fgSetupPixelFormat( window, FALSE, PFD_MAIN_PLANE );
+            fgSetupPixelFormat( window, GL_FALSE, PFD_MAIN_PLANE );
 
-            if( fgState.UseCurrentContext != TRUE )
+            if( ! fgState.UseCurrentContext )
                 window->Window.Context =
                     wglCreateContext( window->Window.Device );
             else
@@ -1134,7 +1142,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
             }
         }
 
-        window->State.NeedToResize = TRUE;
+        window->State.NeedToResize = GL_TRUE;
         ReleaseDC( window->Window.Handle, window->Window.Device );
         break;
 
@@ -1146,12 +1154,12 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
         break;
 #if 0
     case WM_SETFOCUS: 
-        printf("WM_SETFOCUS: %p\n", window );
+        printf( "WM_SETFOCUS: %p\n", window );
         lRet = DefWindowProc( hWnd, uMsg, wParam, lParam );
         break;
 
     case WM_ACTIVATE: 
-        if (LOWORD(wParam) != WA_INACTIVE)
+        if( LOWORD( wParam ) != WA_INACTIVE )
         {
             /* glutSetCursor( fgStructure.Window->State.Cursor ); */
             printf("WM_ACTIVATE: glutSetCursor( %p, %d)\n", window,
@@ -1167,23 +1175,30 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
         /*
          * Windows seems to need reminding to erase the cursor for NONE.
          */
+
+        /*
+         * XXX Is this #if 0 section anything that we need to worry
+         * XXX about?  Can we delete it?  If it will ever be used,
+         * XXX why not re-use some common code with the glutSetCursor()
+         * XXX function (or perhaps invoke glutSetCursor())?
+         */
 #if 0
-        if ((LOWORD(lParam) == HTCLIENT) &&
-            (fgStructure.Window->State.Cursor == GLUT_CURSOR_NONE))
+        if( ( LOWORD( lParam ) == HTCLIENT ) &&
+            ( fgStructure.Window->State.Cursor == GLUT_CURSOR_NONE ) )
           SetCursor( NULL );
 #else
 
         /* Set the cursor AND change it for this window class. */
-#define MAP_CURSOR(a,b)                 \
-    case a:                             \
-    SetCursor( LoadCursor( NULL, b ) ); \
-    break;
+#define MAP_CURSOR(a,b)                     \
+    case a:                                 \
+        SetCursor( LoadCursor( NULL, b ) ); \
+        break;
 
         /* Nuke the cursor AND change it for this window class. */
-#define ZAP_CURSOR(a,b) \
-    case a:             \
-    SetCursor( NULL );  \
-    break;
+#define ZAP_CURSOR(a,b)     \
+    case a:                 \
+        SetCursor( NULL );  \
+        break;
 
         if( LOWORD( lParam ) == HTCLIENT )
             switch( window->State.Cursor )
@@ -1210,8 +1225,8 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
         break;
 
     case WM_SHOWWINDOW:
-        window->State.Visible = TRUE;
-        window->State.Redisplay = TRUE;
+        window->State.Visible = GL_TRUE;
+        window->State.Redisplay = GL_TRUE;
         break;
 
     case WM_PAINT:
@@ -1228,8 +1243,8 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
          */
         if( fgStructure.Window == window )
         {
-            int used = FALSE ;
-            SFG_Window *iter ;
+            int used = FALSE;
+            SFG_Window *iter;
 
             wglMakeCurrent( NULL, NULL );
             /*
@@ -1245,7 +1260,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
                     used = TRUE;
             }
 
-            if( used == FALSE )
+            if( ! used )
                 wglDeleteContext( window->Window.Context );
         }
 
@@ -1253,7 +1268,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
          * Put on a linked list of windows to be removed after all the
          * callbacks have returned
          */
-        fgAddToWindowDestroyList( window, FALSE );
+        fgAddToWindowDestroyList( window, GL_FALSE );
         DestroyWindow( hWnd );
         break;
 
@@ -1270,12 +1285,12 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
         
         if ( window->ActiveMenu )
         {
-            window->State.Redisplay = TRUE;
+            window->State.Redisplay = GL_TRUE;
             fgSetWindow ( window->ActiveMenu->ParentWindow );
             break;
         }
 
-        window->State.Modifiers = fgGetWin32Modifiers( );
+        fgState.Modifiers = fgGetWin32Modifiers( );
 
         if( ( wParam & MK_LBUTTON ) ||
             ( wParam & MK_MBUTTON ) ||
@@ -1286,7 +1301,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
             INVOKE_WCB( *window, Passive, ( window->State.MouseX,
                                             window->State.MouseY ) );
 
-        window->State.Modifiers = 0xffffffff;
+        fgState.Modifiers = 0xffffffff;
     }
     break;
 
@@ -1297,28 +1312,37 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
     case WM_MBUTTONUP:
     case WM_RBUTTONUP:
     {
-        GLboolean pressed = TRUE;
+        GLboolean pressed = GL_TRUE;
         int button;
 
         window->State.MouseX = LOWORD( lParam );
         window->State.MouseY = HIWORD( lParam );
 
+        /*
+         * XXX Either these multi-statement lines should be broken
+         * XXX in the form:
+         * XXX     pressed = GL_TRUE;
+         * XXX     button = GLUT_LEFT_BUTTON;
+         * XXX     break;
+         * XXX ...or we should use a macro (much as I dislike freeglut's
+         * XXX preponderance of using macros to "compress" code).
+         */
         switch( uMsg )
         {
         case WM_LBUTTONDOWN:
-            pressed = TRUE;  button = GLUT_LEFT_BUTTON;   break;
+            pressed = GL_TRUE;  button = GLUT_LEFT_BUTTON;   break;
         case WM_MBUTTONDOWN:
-            pressed = TRUE;  button = GLUT_MIDDLE_BUTTON; break;
+            pressed = GL_TRUE;  button = GLUT_MIDDLE_BUTTON; break;
         case WM_RBUTTONDOWN:
-            pressed = TRUE;  button = GLUT_RIGHT_BUTTON;  break;
+            pressed = GL_TRUE;  button = GLUT_RIGHT_BUTTON;  break;
         case WM_LBUTTONUP:
-            pressed = FALSE; button = GLUT_LEFT_BUTTON;   break;
+            pressed = GL_FALSE; button = GLUT_LEFT_BUTTON;   break;
         case WM_MBUTTONUP:
-            pressed = FALSE; button = GLUT_MIDDLE_BUTTON; break;
+            pressed = GL_FALSE; button = GLUT_MIDDLE_BUTTON; break;
         case WM_RBUTTONUP:
-            pressed = FALSE; button = GLUT_RIGHT_BUTTON;  break;
+            pressed = GL_FALSE; button = GLUT_RIGHT_BUTTON;  break;
         default:
-            pressed = FALSE; button = -1;                 break;
+            pressed = GL_FALSE; button = -1;                 break;
         }
 
         if( GetSystemMetrics( SM_SWAPBUTTON ) )
@@ -1331,6 +1355,9 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
             return DefWindowProc( hWnd, uMsg, lParam, wParam );
 
         /*
+         * XXX This comment is duplicated in two other spots.
+         * XXX Can we centralize it?
+         *
          * Do not execute the application's mouse callback if a
          * menu is hooked to this button.
          * In that case an appropriate private call should be generated.
@@ -1350,8 +1377,13 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
         /* Window has an active menu, it absorbs any mouse click */
         if( window->ActiveMenu )
         {
-            /* Inside the menu, invoke the callback and deactivate the menu*/
-            if( fgCheckActiveMenu( window, window->ActiveMenu ) == TRUE )
+            /* Outside the menu, deactivate the menu if it's a downclick */
+            if( ! fgCheckActiveMenu( window, window->ActiveMenu ) )
+            {
+                if( pressed )
+                    fgDeactivateMenu( window->ActiveMenu->ParentWindow );
+            }
+            else  /* In menu, invoke the callback and deactivate the menu*/
             {
                 /*
                  * Save the current window and menu and set the current
@@ -1371,25 +1403,20 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
                 fgSetWindow( save_window );
                 fgStructure.Menu = save_menu;
             }
-            else  /* Out of menu, deactivate the menu if it's a downclick */
-            {
-                if( pressed == TRUE )
-                    fgDeactivateMenu( window->ActiveMenu->ParentWindow );
-            }
 
             /*
              * Let's make the window redraw as a result of the mouse
              * click and menu activity.
              */
             if( ! window->IsMenu )
-                window->State.Redisplay = TRUE;
+                window->State.Redisplay = GL_TRUE;
 
             break;
         }
 
-        if ( ( window->Menu[ button ] ) && ( pressed == TRUE ) )
+        if ( window->Menu[ button ] && pressed )
         {
-            window->State.Redisplay = TRUE;
+            window->State.Redisplay = GL_TRUE;
             fgSetWindow( window );
             fgActivateMenu( window, button );
 
@@ -1400,28 +1427,30 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
             break;
 
         fgSetWindow( window );
-        fgStructure.Window->State.Modifiers = fgGetWin32Modifiers( );
+        fgState.Modifiers = fgGetWin32Modifiers( );
 
         INVOKE_WCB(
             *window, Mouse,
             ( button,
-              pressed == TRUE ? GLUT_DOWN : GLUT_UP,
+              pressed ? GLUT_DOWN : GLUT_UP,
               window->State.MouseX,
               window->State.MouseY
             )
         );
 
-        fgStructure.Window->State.Modifiers = 0xffffffff;
+        fgState.Modifiers = 0xffffffff;
     }
     break;
 
     case 0x020a:
         /* Should be WM_MOUSEWHEEL but my compiler doesn't recognize it */
     {
+        /*
+         * XXX THIS IS SPECULATIVE -- John Fay, 10/2/03
+         * XXX Should use WHEEL_DELTA instead of 120
+         */
         int wheel_number = LOWORD( wParam );
-        /* THIS IS SPECULATIVE -- John Fay, 10/2/03 */
         short ticks = ( short )HIWORD( wParam ) / 120;
-        /* Should be WHEEL_DELTA instead of 120 */
         int direction = 1;
 
         if( ticks < 0 )
@@ -1443,7 +1472,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
             break;
 
         fgSetWindow( window );
-        fgStructure.Window->State.Modifiers = fgGetWin32Modifiers( );
+        fgState.Modifiers = fgGetWin32Modifiers( );
 
         while( ticks-- )
             if( FETCH_WCB( *window, MouseWheel ) )
@@ -1473,15 +1502,15 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
                 );
             }
 
-        fgStructure.Window->State.Modifiers = 0xffffffff;
+        fgState.Modifiers = 0xffffffff;
     }
-    break ;
+    break;
 
     case WM_SYSKEYDOWN:
     case WM_KEYDOWN:
     {
         int keypress = -1;
-        POINT mouse_pos ;
+        POINT mouse_pos;
 
         if( fgState.IgnoreKeyRepeat && (lParam & KF_REPEAT) )
             break;
@@ -1490,7 +1519,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
          * Remember the current modifiers state. This is done here in order 
          * to make sure the VK_DELETE keyboard callback is executed properly.
          */
-        window->State.Modifiers = fgGetWin32Modifiers( );
+        fgState.Modifiers = fgGetWin32Modifiers( );
 
         GetCursorPos( &mouse_pos );
         ScreenToClient( window->Window.Handle, &mouse_pos );
@@ -1542,7 +1571,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
                           window->State.MouseX, window->State.MouseY )
             );
 
-        window->State.Modifiers = 0xffffffff;
+        fgState.Modifiers = 0xffffffff;
     }
     break;
 
@@ -1556,7 +1585,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
          * Remember the current modifiers state. This is done here in order 
          * to make sure the VK_DELETE keyboard callback is executed properly.
          */
-        window->State.Modifiers = fgGetWin32Modifiers( );
+        fgState.Modifiers = fgGetWin32Modifiers( );
 
         GetCursorPos( &mouse_pos );
         ScreenToClient( window->Window.Handle, &mouse_pos );
@@ -1625,7 +1654,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
                           window->State.MouseX, window->State.MouseY )
             );
 
-        window->State.Modifiers = 0xffffffff;
+        fgState.Modifiers = 0xffffffff;
     }
     break;
 
@@ -1643,12 +1672,12 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
          */
         if( FETCH_WCB( *window, Keyboard ) )
         {
-            window->State.Modifiers = fgGetWin32Modifiers( );
+            fgState.Modifiers = fgGetWin32Modifiers( );
             INVOKE_WCB( *window, Keyboard,
                         ( (char)wParam,
                           window->State.MouseX, window->State.MouseY )
             );
-            window->State.Modifiers = 0xffffffff;
+            fgState.Modifiers = 0xffffffff;
         }
     }
     break;
@@ -1688,7 +1717,7 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
 
     case WM_SYNCPAINT:  /* 0x0088 */
         /* Another window has moved, need to update this one */
-        window->State.Redisplay = TRUE;
+        window->State.Redisplay = GL_TRUE;
         lRet = DefWindowProc( hWnd, uMsg, wParam, lParam );
         /* Help screen says this message must be passed to "DefWindowProc" */
         break;
@@ -1709,58 +1738,57 @@ LRESULT CALLBACK fgWindowProc( HWND hWnd, UINT uMsg, WPARAM wParam,
            */
             switch ( lParam )
             {
-            case SC_SIZE       :
-                break ;
+            case SC_SIZE:
+                break;
 
-            case SC_MOVE       :
-                break ;
+            case SC_MOVE:
+                break;
 
-            case SC_MINIMIZE   :
+            case SC_MINIMIZE:
                 /* User has clicked on the "-" to minimize the window */
                 /* Turn off the visibility */
-                window->State.Visible = GL_FALSE ;
-
-                break ;
+                window->State.Visible = GL_FALSE;
+                break;
 
-            case SC_MAXIMIZE   :
-                break ;
+            case SC_MAXIMIZE:
+                break;
 
-            case SC_NEXTWINDOW :
-                break ;
+            case SC_NEXTWINDOW:
+                break;
 
-            case SC_PREVWINDOW :
-                break ;
+            case SC_PREVWINDOW:
+                break;
 
-            case SC_CLOSE      :
+            case SC_CLOSE:
                 /* Followed very closely by a WM_CLOSE message */
-                break ;
+                break;
 
-            case SC_VSCROLL    :
-                break ;
+            case SC_VSCROLL:
+                break;
 
-            case SC_HSCROLL    :
-                break ;
+            case SC_HSCROLL:
+                break;
 
-            case SC_MOUSEMENU  :
-                break ;
+            case SC_MOUSEMENU:
+                break;
 
-            case SC_KEYMENU    :
-                break ;
+            case SC_KEYMENU:
+                break;
 
-            case SC_ARRANGE    :
-                break ;
+            case SC_ARRANGE:
+                break;
 
-            case SC_RESTORE    :
-                break ;
+            case SC_RESTORE:
+                break;
 
-            case SC_TASKLIST   :
-                break ;
+            case SC_TASKLIST:
+                break;
 
-            case SC_SCREENSAVE :
-                break ;
+            case SC_SCREENSAVE:
+                break;
 
-            case SC_HOTKEY     :
-                break ;
+            case SC_HOTKEY:
+                break;
             }
         }